fix: No toast on removal of untrusted mark #16972
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (7)
|
caybro
force-pushed
the
16949-no-toast-on-removal-of-untrusted-mark
branch
from
a650a86 to
3d29949
Compare
- extend the store method with a "displayName" param - emit a toast/notification when we remove someone's "untrusted" mark Fixes #16949
caybro
force-pushed
the
16949-no-toast-on-removal-of-untrusted-mark
branch
from
3d29949 to
4501e9e
Compare
jrainville
reviewed
Dec 16, 2024
|
|
||
| const contactDetails = Utils.getContactDetailsAsJson(pubKey, false, false, true) | ||
| const displayName = SQUtils.Emoji.parse(ProfileUtils.displayName(contactDetails.localNickname, contactDetails.name, contactDetails.displayName, contactDetails.alias)) | ||
| Global.displaySuccessToastMessage(qsTr("Untrusted mark removed for %1").arg(displayName)) |
There was a problem hiding this comment.
It would be better to have the call start from the Nim side, since it might have failed.
We call the event SIGNAL_REMOVED_TRUST_STATUS if the action succeeded. You can hook into one of the modules that listens to that event and then call the usual signal to have a ToastMessage
There was a problem hiding this comment.
I'll have a look yeah, good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16949
Affected areas
Profile
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Marked as untrusted:
Removed the untrusted mark:
